Re: [libvirt] [PATCH] qemu: hotplug: Release address properly when redirected device attach failure

On 05/30/2017 07:22 AM, Shivaprasad G Bhat wrote:

The virDomainUSBAddressEnsure returns 0 or -1 and checking for 1 is wrong. Fix it.

Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> --- src/qemu/qemu_hotplug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: John Ferlan <jferlan@redhat.com> FWIW: It seems commit id de325472 copied the logic from qemuDomainAttachChrDeviceAssignAddr... I altered the commit message slightly and pushed.... Tks, John