Re: [libvirt] [PATCH 0/5] virStorageBackendWipeLocal cleanups

On 12/11/2015 11:36 AM, Ján Tomko wrote: > The first patch fixes the return values of virStorageWipe on non-sparse local files > in the case of a partial wipe or a fdatasync error. > > The rest reduces the number of parameters of virStorageBackendWipe{Extent,}Local. > > Ján Tomko (5): > storage: fix return values of virStorageBackendWipeExtentLocal > storage: move buffer allocation inside > virStorageBackendWipeExtentLocal > storage: drop 'Extent' from virStorageBackendWipeExtentLocal > virStorageBackendWipeLocal: use unsigned long long instead of off_t > virStorageBackendWipeLocal: remove bytes_wiped argument > > src/storage/storage_backend.c | 53 +++++++++++++++++-------------------------- > 1 file changed, 21 insertions(+), 32 deletions(-) > Patch 1 note: (choose to add if you wish) The errno is printed anyway and thus unless someone overwrites your message should be passed back to the caller...

I did make a comment in patch 3 - your call on how to handle. ACK series