On Tue, Jan 3, 2012 at 6:24 PM, Zeeshan Ali (Khattak) <zeeshanak@gnome.org> wrote:
On Tue, Jan 3, 2012 at 6:06 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
On Tue, Jan 03, 2012 at 05:35:39PM +0200, Zeeshan Ali (Khattak) wrote:
On Tue, Jan 3, 2012 at 5:31 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
On Tue, Jan 03, 2012 at 05:18:41PM +0200, Zeeshan Ali (Khattak) wrote:
I haven't really checked with other languages but vala tools get confused because we claim that GVirConfig is the namespace but then the macros aren't named accordingly. I can get you the exact errors I got from valac if you like
Confused how? I was under the impression that you had been using libvirt-gconfig with vala in gnome-boxes without hitting any huge issues, but mostly missing API, is this a wrong impression I have?
*Mostly*, yes! During all these vacation, I lost track of which change exactly triggers this issue but it was some new API you added to the lib. Do you really need me to find out which one was it?
Well, you're trying to push a huge invasive change, it would be helpful to know understand what problems exactly you are having without this change so that an informed decision can be made...
I already provided the needed information: vala gets confused because of the inconsistency in the API. Even if vala doesn't get confused, the inconsistency is a problem and will most definitely cause issues later so it needs to be resolved anyway. I also presented all the possible solutions to the problem (including yours) and showed the issues with every one of them but the one I provided. What exactly would the exact error from valac tell you that I haven't already told?
So FWIW I found the patch in Boxes that causes a problem with current API: https://bugzilla.gnome.org/attachment.cgi?id=204140&action=edit Compiling that patch should lead you to this: vm-configurator.c: In function ‘boxes_vm_configurator_set_video_config’: vm-configurator.c:713:62: error: ‘GVIR_TYPE_DOMAIN_VIDEO_MODEL’ undeclared (first use in this function) vm-configurator.c:713:62: note: each undeclared identifier is reported only once for each function it appears in vm-configurator.c: In function ‘boxes_vm_configurator_set_sound_config’: vm-configurator.c:758:62: error: ‘GVIR_TYPE_DOMAIN_SOUND_MODEL’ undeclared (first use in this function) vm-configurator.c: In function ‘boxes_vm_configurator_set_tablet_config’: vm-configurator.c:804:62: error: ‘GVIR_TYPE_DOMAIN_INPUT_BUS’ undeclared (first use in this function) -- Regards, Zeeshan Ali (Khattak) FSF member#5124 P.S. It needs your recently patches to libvirt-glib.