Re: [libvirt] Is seems necessary to pass "migratable=no/yes" to qemu.

On 2014/9/24 19:49, Ján Tomko wrote: > I think the simplest fix for host-passthrough would be to apply the same > filter host-model has. > > But since using invtsc with host-passthrough requires both +invtsc and > migratable=no, so we'd need to either add a 'migratable' option to > host-passthrough (this would skip the filter and add migratable=on), or allow > fine-tuning the features for host-passthrough too. > > Jan > Additional to the 2 suggestions, will that be OK to remove the codes in qemuProcessVerifyGuestCPU that checks whether the vm->def has invtsc flag while qemu doesn't? - if (STREQ(feature->name, "invtsc") && - !cpuHasFeature(guestcpu, feature->name)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("host doesn't support invariant TSC")); - goto cleanup; - }

Removing these codes, plus with the solution that "add 'migratable' option to host-passthrough", it seems the problem would be gone, and invtsc would not be so 'distinctive' in libvirt any more. -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list