On Wed, Apr 08, 2020 at 04:12:04PM -0500, Jonathon Jongsma wrote:
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
@@ -503,14 +503,13 @@ virNWFilterGetXMLDesc(virNWFilterPtr nwfilter, unsigned int flags) int virNWFilterRef(virNWFilterPtr nwfilter) { - VIR_DEBUG("nwfilter=%p refs=%d", nwfilter, - nwfilter ? nwfilter->parent.u.s.refs : 0); + VIR_DEBUG("nwfilter=%p", nwfilter);
I wonder about this change. If it doesn't include the ref count in the debug message, is it actually still useful to anyone? I've never used it, so I don't know. If we want to keep it, we could of course access the GObject ref_count member variable.
I think just drop the ref count is fine. I wouldn't want us to be accessing private fields in GObject Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|