Re: [libvirt] [PATCHv4 0/2] lxc keep/drop capabilities
On 07/23/14 09:17, Gao feng wrote:
On 07/18/2014 04:02 PM, Cédric Bosdonnat wrote:
> Hi all,
>
> Even though the v3 has been ACKed (but not pushed), I rebased it on top of
> master before pushing it and did a few changes that are worth checking before.
>
> * Path 1 (feature) and 3 (doc) of the previous version merge merged together as
> suggested for another similar series.
>
> * virCgroupAllowDevice() has been changed to use negative major / minor device
> values to output '*'. I never saw any of them negative, but I don't
have a
> good knowledge of that.
>
ACK & Pushed, thanks!
Please compile the code before pushing! This broke the build:
CC lxc/libvirt_driver_lxc_impl_la-lxc_cgroup.lo
In file included from /usr/include/cap-ng.h:27:0,
from lxc/lxc_container.c:48:
lxc/lxc_container.c: In function 'lxcContainerDropCapabilities':
lxc/lxc_container.c:1951:35: error: comparison of unsigned expression >= 0 is always
true [-Werror=type-limits]
if (!cap_valid(capsMapping[i]))
^
cc1: all warnings being treated as errors
make[3]: *** [lxc/libvirt_driver_lxc_impl_la-lxc_container.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
lxc/lxc_cgroup.c: In function 'virLXCCgroupSetupDeviceACL':
lxc/lxc_cgroup.c:354:9: error: jump skips variable initialization
[-Werror=jump-misses-init]
goto cleanup;
^
lxc/lxc_cgroup.c:456:2: note: label 'cleanup' defined here
cleanup:
^
lxc/lxc_cgroup.c:357:9: note: 'capMknod' declared here
int capMknod = def->caps_features[VIR_DOMAIN_CAPS_FEATURE_MKNOD];
^
cc1: all warnings being treated as errors
Fixup patch comming soon.
Peter
Attachments:
- signature.asc (application/pgp-signature — 884 bytes)