On Tue, Jan 30, 2024 at 07:42:10 -0800, Andrea Bolognani wrote:
On Tue, Jan 30, 2024 at 12:18:43PM +0000, Daniel P. Berrangé wrote:
On Tue, Jan 30, 2024 at 12:39:29PM +0100, Michal Prívozník wrote:
On 1/26/24 11:21, Andrea Bolognani wrote:
Can you please take another look at this patch (as well as the other one that contains alpha-specific changes) in light of the arguments that I've provided above? Thanks.
I don't want to override Dan, but to me this makes sense. Unless he disagrees, you have my:
Go for it.
I still maintain no one should waste a second of effort on an architecture that was dead before libvirt even started as a project, but won't block this.
Thanks, I appreciate that!
Any chance either of you could look at the other patch[1] as well? The connection to alpha is sort of tangential in that case, what's more important is that we're currently not using -fstack-protector on aarch64 even though we should.
IMO there you should post a version which just enables -fstack-protector everywhere, as in ... drop the alpha hack. That one is starting to go beyond the 'trivial' change.