Re: [libvirt] [RFC][PATCH] storage: allow alphabetical names in owner/group of permissions
On Sun, Mar 15, 2009 at 02:47:14AM +0900, Ryota Ozaki wrote:
Hi,
This patch allows to specify owner/group of permissions in storage XML
as alphabetical names.
One concern of this patch is since alphabetical names are converted
to uid/gid at XML parsing (e.g., virsh pool-define some-pool.xml),
the generated XML file for libvirt internal does not contain the original
alphabetical names and dumpxml does not as well. Is it better the
conversion is done when activated not defined?
Yes, I'm wondering about this. Usually it's better if the XML
can round-trip without change (i.e. the exported version is the
same as the imported one), modulo maybe some reordering of elements.
But loosing information or distortions in the cycle tend to generate
problems. So I'm wondering what is in your opinion the added value
of having livirt do that conversion instead of the layer on top of
libvirt.
There is the added problem that the given name might not be portable
from one node to another, that's true too for uid/gid values but for
example in the case of networked filesystems, the hardcoded numbers are
actually more portable than the high level name equivalents.
So I'm not sure really if the advantage really outweight clearly
the potential problems. I don't know, it's probably a matter of use
cases.
Otherwise the patch looks fine to me, test case may be harder due
to the non-portability of the names.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/