On 02/06/2015 11:11 AM, Marek Marczykowski-Górecki wrote:
On Fri, Feb 06, 2015 at 05:36:40PM +0000, Daniel P. Berrange wrote:
On Thu, Feb 05, 2015 at 06:17:08AM +0100, Marek Marczykowski-Górecki wrote:
At least Xen supports backend drivers in another domain (aka "driver domain"). This patch introduces XML config option for such setting as 'domain' attribute of 'source' element. Verification its content is left for the driver.
Ok, but perhaps some better name? When I read something like: <interface type='bridge'> <ip address='1.2.3.4'/> <domain name='netvm'/> </interface> it is really not obvious what domain this is about. When the same would be supported for PCI passthrough, it will be even more confusing: <interface type='hostdev' managed='yes'> <driver name='vfio'/> <source> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </source> <mac address='52:54:00:6d:90:02'/> <domain name='netvm'/> </interface>
Any ideas for a better name?
Maybe allow a new type of <driver> element? <interface type='hostdev' managed='yes'> <driver name='domain-vfio'> <domain name='netvm'/> </driver> <source>...</source> </interface> Maybe not. But I agree that we want to nail the XML naming convention first. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org