On 06/17/2013 09:05 AM, Osier Yang wrote:
> On 12/06/13 15:49, Michal Privoznik wrote:
>> On 11.06.2013 16:59, Franky Van Liedekerke wrote:
>>> So it seems two issues are present here:
>>>
>>> 1) it searches for /sys/class/fc_host//host0/max_npiv_vports for both
>>> host1 and host2. Imho this path needs to be
>>> /sys/class/fc_host//host1/max_npiv_vports and
>>> /sys/class/fc_host//host2/max_npiv_vports respectively.
>>>
>> I guess you're right. Osier?
>>
>>
> Yes, it's expected so.
>
> It reports the correct host number.
>
> 2013-06-11 13:43:49.159+0000: 3336: error : detect_scsi_host_caps:87 :
> Failed to read max_npiv_vports for host1
>
> But produces incorrect file path with the same host number. However,
> I have no idea why it happened from code. And we have test for the
> util helpers. If it has problems, the test should fail too.
>
> Osier
>
Sorry, I forgot to comment on this thread.
It's fixed already by:
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=371c155