[Libvir] Re: [PATCH 3/7] Add option to pass stdin fd to virExec
Daniel P. Berrange wrote:
> > If nonzero, uses the supplied fd instead of /dev/null.
> > Update callers accordingly.
>
> Looks fine to me, we already have stdout and stderr, it's sensible. +1
Looks OK, but shouldn't we use -1 as the magic value here, since 0 is also
a valid file descriptor.
Yeah, that was me taking advantage of the fact that the qemu_vm
structure is initialized to 0. I'll change that to -1 and make sure
all qemu_vm users initialize stdinFd correctly.
-jim