On Tue, Mar 04, 2014 at 10:11:39AM -0700, Eric Blake wrote:
On 03/04/2014 08:39 AM, Tomoki Sekiyama wrote:
This patchset adds virDomainFSFreeze()/virDomainFSThaw() APIs and virsh domfsfreeze/domfsthaw commands to enable the users to freeze and thaw domain's filesystems cleanly.
Thanks. Based on previous discussion on last November, now I'm getting ready to Post "virDomainQuiesce" version, which does fsfreeze and fsthaw in a single API,
No - the discussion back in November was questioning whether a callback would work, and the decision was that it was too complicated. Go with two API (freeze and thaw) and merely make sure that we lock out any other command that won't work while a freeze is in effect.
Yep, I don't believe a single API will work, and we should have separate calls. We just need to track the sanity internally to the QEMU driver. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|