On 05/21/2012 01:59 PM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
The libvirt_test.la library was introduced to allow test suites to reference internal-only symbols. These days, nearly every symbol we care about is in src/libvirt_private.syms, so there is no need for libvirt_test.la to continue to exist
* src/Makefile.am: Delete libvirt_test.la & add new .syms files * src/libvirt_private.syms: Export symbols needed by test suite * tests/Makefile.am: Link to libvirt_test.la. Ensure LXC tests link to network_driver.la * src/libvirt_esx.syms, src/libvirt_openvz.syms: Add exports neede
s/neede/needed/
by test suite --- configure.ac | 1 + src/Makefile.am | 33 +++++++++----------- src/libvirt_esx.syms | 7 ++++ src/libvirt_openvz.syms | 7 ++++ src/libvirt_private.syms | 41 ++++++++++++++++++++++++- tests/Makefile.am | 75 ++++++++++++++++++++++----------------------- 6 files changed, 107 insertions(+), 57 deletions(-) create mode 100644 src/libvirt_esx.syms create mode 100644 src/libvirt_openvz.syms
Alas, this isn't passing for me: CCLD libvirt.la *** Warning: Linking the shared library libvirt.la against the non-libtool *** objects probes.o is not portable! ../gnulib/lib/.libs/libgnu.a(allocator.o):(.data.rel.ro+0x0): multiple definition of `stdlib_allocator' ./.libs/libvirt_driver_xenapi.a(allocator.o):(.data.rel.ro+0x0): first defined here ... I'm not sure where we have a duplicate link line, but there's obviously still something that needs trimming.
+++ b/src/libvirt_esx.syms @@ -0,0 +1,7 @@ +# +# These symbols are dependent upon --with-openvz via WITH_OPENVZ
Really? [Too much copy-and-paste] Other than that, things look reasonable, but it's hard to know for sure without a full test. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org