Re: [libvirt] [PATCH] build: fix parted detection at configure time

On 01/31/2011 05:10 PM, Eric Blake wrote: > * configure.ac (PARTED_FOUND): Issue configure error if > --with-storage-disk=yes but no parted is found. > > - if test "$with_storage_disk" != "no"&& test "x$PKG_CONFIG" != "x" > ; then > - PKG_CHECK_MODULES(LIBPARTED, libparted>= $PARTED_REQUIRED, [], > [PARTED_FOUND=no]) > + if test "$PARTED_FOUND" = yes&& test "x$PKG_CONFIG" != "x" ; then Just one small nit - almost everywhere else in configure.ac, the yes or no is quoted, but here you haven't quoted it. Operationally it makes no difference, it just looks "different" :-) At any rate, ACK.