Re: [libvirt] virsh bash completion file

Quoting Daniel P. Berrange (berrange(a)redhat.com): > On Wed, Oct 05, 2011 at 03:17:47PM -0500, Serge E. Hallyn wrote: > > Hi, > > > > I've been trying out a bash autocompletion file by Geoff Low (slight hack > > by me, don't blame him for my hack), and it's working pretty nicely. > > I'm not sure where to put it in the git tree, but it seems like it'd be > > nice to have upstream? > > David Lutterkort previously suggested this > > https://www.redhat.com/archives/libvir-list/2007-October/msg00231.html > > And I didn't ever notice that and so wrote one myself > > https://www.redhat.com/archives/libvir-list/2008-July/msg00175.html > https://www.redhat.com/archives/libvir-list/2008-July/msg00177.html > > Neither ever got committed. There were some things I didn't much like > about mine, but I can't really remember now. > > Third time lucky perhaps :-) So the things you didn't much like must not have been *too* bad? :) Are you going to make some changes and resubmit, or would you like me to test (and port as needed) the above patches first?