Re: [libvirt] [PATCHv2 14/27] test: reject unknown flags
On 07/13/2011 06:35 AM, Matthias Bolte wrote:
2011/7/8 Eric Blake <eblake(a)redhat.com>:
> static int testDomainCoreDump(virDomainPtr domain,
> const char *to,
> - unsigned int flags ATTRIBUTE_UNUSED)
> + unsigned int flags)
> {
> testConnPtr privconn = domain->conn->privateData;
> int fd = -1;
> @@ -1912,6 +1914,8 @@ static int testDomainCoreDump(virDomainPtr domain,
> virDomainEventPtr event = NULL;
> int ret = -1;
>
> + virCheckFlags(0, -1);
testDomainCoreDump understands VIR_DUMP_CRASH. Don't get fooled by the
ATTRIBUTE_UNUSED :)
Good catch.
ACK, with testDomainCoreDump fixed.
I've pushed 11-14, with this squashed in.
diff --git i/src/test/test_driver.c w/src/test/test_driver.c
index 5412bff..f3fb320 100644
--- i/src/test/test_driver.c
+++ w/src/test/test_driver.c
@@ -1919,7 +1919,7 @@ static int testDomainCoreDump(virDomainPtr domain,
virDomainEventPtr event = NULL;
int ret = -1;
- virCheckFlags(0, -1);
+ virCheckFlags(VIR_DUMP_CRASH, -1);
testDriverLock(privconn);
privdom = virDomainFindByName(&privconn->domains,
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)