On Sat, 2016-05-14 at 17:39 -0400, Cole Robinson wrote:
All qemu versions we support have QEMU_CAPS_DEVICE, so checking for it is redundant. Remove the usage. The code diff isn't clear, but all that code is just inindented with no other change.
'git show -w' is your friend ;) This information, however, should probably be moved out of the commit message and after the '---' separator.
Test cases that hit qemuDomainAssignAddresses but don't have infrastructure for specifying qemuCaps values see lots of churn, since now PCI addresses are in the XML output.
So, I want to make sure I'm getting this right: the addresses should have been there in the first place, and would be if we were processing the input files in the real world, outside of the test suite; however, since the addresses being there depend on QEMU_CAPS_DEVICE, and some test cases run with an empty virQEMUCaps, they never appeared until we got rid of the check on QEMU_CAPS_DEVICE. ACK if the above makes sense. -- Andrea Bolognani Software Engineer - Virtualization Team