Re: [libvirt] [PATCH 47/47] vircgroup: rename controllers to legacy
On Thu, Sep 20, 2018 at 10:11 AM, Pavel Hrdina <phrdina(a)redhat.com> wrote:
On Thu, Sep 20, 2018 at 08:31:52AM +0200, Fabiano Fidêncio wrote:
> On Tue, Sep 18, 2018 at 5:46 PM, Pavel Hrdina <phrdina(a)redhat.com>
wrote:
>
> > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> >
>
> Pavel,
>
> I'm not sure what your next series is doing but why renaming the
> controllers to legacy?
Right, I forget to add some reasoning into commit message. So with the
introduction of cgroup v2 there are new names used with cgroups based
on which version is used:
- legacy: cgroup v1
- unified: cgroup v2
- hybrid: cgroup v1 and cgroup v2
So I can rename it to 'cgroupv1' but I thought that 'legacy' is better
name to use in our code.
legacy is fine as long as this reasoning is into the commit message.
Considering you'll add it:
Reviewed-by: Fabiano Fidêncio <fidencio(a)redhat.com>
Pavel
Attachments:
- attachment.html (text/html — 1.7 KB)