On Thu, Apr 17, 2025 at 06:11:56PM +0100, Daniel P. Berrangé wrote:
From: Daniel P. Berrangé <berrange@redhat.com>
When no URI is set we try to guess what daemon to connect to by looking for any listening sockets. If there are no listening sockets, however, we don't even know what daemon the user expected to connect to. The error message in this case is not especially clear
This tweaks the error message to try to make the problem easier to understand.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Sorry, one thing: Do you need to add a link to Ming's bug report? eg: Fixes: https://issues.redhat.com/browse/RHEL-87177 Rich.
--- src/remote/remote_sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c index 8d403b6f01..4e6d19098c 100644 --- a/src/remote/remote_sockets.c +++ b/src/remote/remote_sockets.c @@ -398,7 +398,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport,
if (!direct_sock_name) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Cannot use direct socket mode if no URI is set. For more information see https://libvirt.org/kbase/failed_connection_after_install.html")); + _("No URI is provided and cannot identify any listening daemon socket path to attempt to connect to. Please ensure the expected daemon sockets are active and/or provide an explicit URI. For more information see https://libvirt.org/kbase/failed_connection_after_install.html")); return NULL; }
-- 2.48.1
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top