Re: [libvirt] [PATCH 2/3] conf: Add a comment warning about boolean feature XML
On 04/17/2018 02:40 PM, Cole Robinson wrote:
This is the old style and we really shouldn't be adding any more
examples like this. Add a comment to warn devs away
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
---
docs/schemas/domaincommon.rng | 6 +++++-
src/conf/domain_conf.c | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
The domaincommon.rng change should go in patch 1.
I'll leave it up to you whether to combine the domain_conf.c change as well.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John