Re: [libvirt] [PATCH v2 2/9] hostdev: Use common reattach code to rollback prepare errors
On Tue, 2016-01-26 at 18:55 -0500, John Ferlan wrote:
Need something here...
Perhaps to the effect of instead of inlining most of
virHostdevOnlyReattachPCIDevice, call virHostdevOnlyReattachPCIDevice.
Sure.
One extra "call" or check being made by doing this is the
virPCIDeviceGetStubDriver check and virPCIDeviceWaitForCleanup. Are
there any "timing" considerations from this path? Now for every PCI
hostdev found, we'll call *WaitForCleanup. That should perhaps be noted.
I think doing so should be fairly safe, possibly even desiderable.
Let's see if anyone believes otherwise :)
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team