Re: [libvirt] [PATCH 0/2] about Virsh Command Reference

On 08/16/2011 07:34 AM, Justin Clift wrote: >On 16/08/2011, at 1:04 PM, Hu Tao wrote: >>On Tue, Jul 26, 2011 at 11:03:52AM +0800, Hu Tao wrote: >>>Hi, >>> >>> We now have libvirt advanced at 0.9.3, but there is almost no >>> progress has been made on Virsh Command Reference. For future reference, it would help to put [libvirt-virshcmdref] in the subject line, to make it obvious that the patch is in relation to libvirt-virshcmdref.git instead of the primary libvirt.git. >>>I'm now >>> starting on updating Virsh Command Reference to get it synced >>> with libvirt/virsh, but since I'm not a native-English speaker, >>> there must be grammers, typos, etc. in the documents written >>> by me, so any comments on these are appreciated. Besides, >>> comments on other errors, such as example usages, are also >>> welcome. >>> >>> In this series, docs for two cmmands are updated. I'll post more >>> patches for other commands subsequently. >>> >>>Hu Tao (2): >>> update documentation for command attach-disk >>> update documentation for command detach-disk >>> >>>source/attach-disk.xml | 292 +++++++++++++++++++++++++++++++++++++++++++++++- >>>source/detach-disk.xml | 233 +++++++++++++++++++++++++++++++++++++- >>>2 files changed, 517 insertions(+), 8 deletions(-) I've gone ahead and pushed these two patches - they looked okay to me, and are strictly better than what was there before. >Is anyone else interested in picking this stuff up? Documentation is indeed important, even if it tends to lag. I'm not sure if I have the right environment set up (I only pushed the source files, but it looks like the practice has also been to store generated files in the virshcmdref repository). When I tried to rebuild things on Fedora 14 with 'make', I got an error: Aug 16, 2011 8:06:01 a.m. org.apache.fop.cli.Main startFOP SEVERE: Exception java.lang.NullPointerException at org.apache.fop.cli.InputHandler.transformTo(InputHandler.java:217) at org.apache.fop.cli.InputHandler.renderTo(InputHandler.java:125) at org.apache.fop.cli.Main.startFOP(Main.java:166) at org.apache.fop.cli.Main.main(Main.java:196) --------- java.lang.NullPointerException at gnu.xml.transform.SAXSerializer.getValue(libgcj.so.11) at org.apache.fop.fo.PropertyList.addAttributesToList(PropertyList.java:283) at org.apache.fop.fo.FObj.processNode(FObj.java:122) ... so if someone is more familiar with publican, help would be welcome.