Re: [libvirt] [PATCH 6/6] tests: Add tests for virtio-rng device handling
On 02/19/13 14:20, John Ferlan wrote:
On 02/13/2013 05:59 AM, Peter Krempa wrote:
> Adds XML parsing and qemu commandline tests for the VirtIO RNG device
> support.
> ---
> .../qemuxml2argv-virtio-rng-egd.args | 1 +
> .../qemuxml2argv-virtio-rng-egd.xml | 26 ++++++++++++++++++++++
> .../qemuxml2argv-virtio-rng-random.args | 1 +
> .../qemuxml2argv-virtio-rng-random.xml | 23 +++++++++++++++++++
> tests/qemuxml2argvtest.c | 5 +++++
> tests/qemuxml2xmltest.c | 3 +++
> 6 files changed, 59 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml
>
ACK - seems OK to me. My only question would be does '/test/phile' have
to exist? That is are there any assumptions that '/test' is present?
As qemu isn't actually started in this test, we don't care if it exists.
Although when started qemu would complain that it can't open the
backend. As the backend is meant to be used on sources like /dev/random
we should not try to relabel or do any stuff to it.
The only place where we could check if the file exists prior to
launching qemu is in qemuProcessStart.
Peter