Re: [libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

Hey Joao, The series looks good to me, but I'm surely not expert enough to give a full ACK.

On Wed, 2016-07-20 at 20:08 +0100, Joao Martins wrote: > Hey, > > This small series implements host cpu description in caps, by getting > topology and xen hwcaps parsing done, followed by having > cpu-{compare,baseline} APIs implemented. Last thing missing I think it > would be to libxl_cpuid_set the features to enable/disable whichever > format we choose plus the appropriate XML convertion to/from XM and XL > config formats. > > Note that since RFC[0] I removed the Get CPU model names API since it > would make more sense having it exported once we do support guest > cpu model/features setting. Changelog included in individual patches > (only second patch got changed) > > Cheers, > Joao > > [0] http://www.redhat.com/archives/libvir-list/2016-July/msg00245.html > > Joao Martins (4): > libxl: describe host topology in capabilities > libxl: describe host cpu features based on hwcaps > libxl: implement virConnectCompareCPU > libxl: implement virConnectBaselineCPU > > src/libxl/libxl_capabilities.c | 168 ++++++++++++++++++++++++++++++++++++++--- > src/libxl/libxl_driver.c | 60 +++++++++++++++ > 2 files changed, 218 insertions(+), 10 deletions(-) > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list