Re: [libvirt] [PATCH 0/3] conf: reject '/' in object names
On 04/26/2016 03:21 PM, Cole Robinson wrote:
An embedded '/' in object names doesn't really work for
any
of our stateful drivers, so let's explicitly reject it.
https://bugzilla.redhat.com/show_bug.cgi?id=639923
https://bugzilla.redhat.com/show_bug.cgi?id=787604
Was there any discussion I may have missed about why we shouldn't escape
characters like this in the name rather than just forbidding them?
This doesn't prevent us doing that in the future if we want though, and
it does provide a useful error message where there was previous
semi-mystery, so ACK to the series (but do we really need the feature
flag for domains? Seems like a bit of overkill.)
Cole Robinson (3):
conf: domain: reject name containing '/'
conf: network: reject name containing '/'
conf: storage: pool: reject name containing '/'
src/conf/domain_conf.c | 8 ++++++++
src/conf/domain_conf.h | 1 +
src/conf/network_conf.c | 6 ++++++
src/conf/storage_conf.c | 6 ++++++
src/openvz/openvz_driver.c | 5 +++--
src/phyp/phyp_driver.c | 1 +
src/vbox/vbox_common.c | 1 +
src/vmx/vmx.c | 3 ++-
src/xenapi/xenapi_driver.c | 1 +
tests/genericxml2xmlindata/generic-name-slash-fail.xml | 17 +++++++++++++++++
tests/genericxml2xmltest.c | 3 +++
11 files changed, 49 insertions(+), 3 deletions(-)
create mode 100644 tests/genericxml2xmlindata/generic-name-slash-fail.xml