Re: [libvirt] [PATCH 3/8] Use a separate buffer for <smartcard> subelements

On Wed, Aug 02, 2017 at 01:12:15PM -0400, Cole Robinson wrote: > On 07/26/2017 09:29 AM, Ján Tomko wrote: >> Convert virDomainSmartcardDefFormat to use a separate buffer >> for possible subelements, to avoid the need for duplicated >> formatting logic in virDomainDeviceInfoNeedsFormat. >> --- >> src/conf/domain_conf.c | 39 +++++++++++++++++++++++---------------- >> 1 file changed, 23 insertions(+), 16 deletions(-) >> > > Looks like this patch causes a regression, currently breaking the virt-manager > test suite that danpb pointed out to me. Edit an existing VM and add > > <smartcard mode='passthrough' type='spicevmc'/> > > The returned XML is invalid: > > <smartcard mode='passthrough'> > type='spicevmc'> > <address type='ccid' controller='0' slot='0'/> > </smartcard> > > Unfortunately there aren't any xml2xml tests for smartcard bits that would > have caught this... > Thanks, I have sent a fix: https://www.redhat.com/archives/libvir-list/2017-August/msg00134.html