Re: [libvirt] [PATCH] qemu: simplify PCI configfd handling in monitor

16 Mar 2011


      * Eric Blake (eblake@redhat.com) wrote:
...
@@ -829,21 +829,19 @@ int qemuDomainAttachHostPciDevice(struct qemud_driver *driver,
         if (qemuDomainPCIAddressEnsureAddr(priv->pciaddrs, &hostdev->info) < 0)
             goto error;
         if (qemuCapsGet(qemuCaps, QEMU_CAPS_PCI_CONFIGFD)) {
-            configfd = qemuOpenPCIConfig(hostdev);
+            if (priv->monConfig->type != VIR_DOMAIN_CHR_TYPE_UNIX) {
+                qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                                _("pci configfd file cannot be attached: "
+                                  "qemu is not using a unix socket monitor"));
Should that be in common sendfd code?

    

Chris Wright