On Thu, Dec 19, 2019 at 5:51 PM Ján Tomko <jtomko@redhat.com> wrote:
On Thu, Dec 19, 2019 at 11:04:13AM +0100, Fabiano Fidêncio wrote:
virGetUserConfigDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary.
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- src/storage/storage_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 580a5e6f15..71078dfbd6 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -278,7 +278,7 @@ storageStateInitialize(bool privileged, } else { configdir = virGetUserConfigDirectory(); rundir = virGetUserRuntimeDirectory(); - if (!(configdir && rundir)) + if (!rundir) goto error;
Looking at virGetUserRuntimeDirectory, that one should always return as well, so you can delete them both (adjusting the commit message)
It's done later in the series, when I change all the virGetUserRuntimeDirectory() cases. Best Regards, -- Fabiano Fidêncio