On Mon, Nov 26, 2012 at 03:17:14PM +0100, Viktor Mihajlovski wrote:
With QMP capability probing, the version was not set. virsh version returns: ... Cannot extract running QEMU hypervisor version
This is fixed by computing caps->version from QMP major, minor, micro values.
Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> --- src/qemu/qemu_capabilities.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a76d108..d92947f 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2377,6 +2377,7 @@ qemuCapsInitQMP(qemuCapsPtr caps, goto cleanup; }
+ caps->version = major * 1000000 + minor * 1000 + micro; caps->usedQMP = true;
qemuCapsInitQMPBasic(caps);
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|