On Thu, Sep 03, 2009 at 01:46:59PM +0200, Jim Meyering wrote:
The only following uses of group look like this:
(always preceded by initialization):
AVAHI_DEBUG("Client collision/connecting %p", mdns->client);
group = mdns->group;
while (group) {
if (group->handle)
avahi_entry_group_reset(group->handle);
group = group->next;
}
So the value used in the initialization at the top is never used.
>From 515e4a4542ce396b8775c618cbe17a30b78299b4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering(a)redhat.com>
Date: Thu, 3 Sep 2009 13:45:22 +0200
Subject: [PATCH] mdns.c: remove dead initialization
* qemud/mdns.c (libvirtd_mdns_client_callback): Remove dead
initialization.
---
qemud/mdns.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemud/mdns.c b/qemud/mdns.c
index ae6ff08..73b7d11 100644
--- a/qemud/mdns.c
+++ b/qemud/mdns.c
@@ -178,7 +178,7 @@ static void libvirtd_mdns_create_services(struct libvirtd_mdns_group
*group) {
static void libvirtd_mdns_client_callback(AvahiClient *c, AvahiClientState state, void
*userdata) {
struct libvirtd_mdns *mdns = (struct libvirtd_mdns *)userdata;
- struct libvirtd_mdns_group *group = mdns->group;
+ struct libvirtd_mdns_group *group;
if (!mdns->client)
mdns->client = c;
ACK
Daniel
--
|: Red Hat, Engineering, London -o-
http://people.redhat.com/berrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org -o-
http://ovirt.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|