Re: [libvirt] [PATCH v3 3/4] NUMA: cleanup for numa related codes

On 2013年03月18日 17:04, Gao feng wrote: > Intend to reduce the redundant code,use virNumaSetupMemoryPolicy > to replace virLXCControllerSetupNUMAPolicy and > qemuProcessInitNumaMemoryPolicy. > > This patch also moves the numa related codes to the > file virnuma.c and virnuma.h > > Signed-off-by: Gao feng&lt;gaofeng(a)cn.fujitsu.com&gt; > --- > include/libvirt/libvirt.h.in | 15 ------ > src/conf/domain_conf.c | 25 +++------ > src/conf/domain_conf.h | 17 +----- > src/libvirt_private.syms | 9 ++-- > src/lxc/lxc_controller.c | 114 +-------------------------------------- > src/qemu/qemu_cgroup.c | 6 +-- > src/qemu/qemu_driver.c | 2 +- > src/qemu/qemu_process.c | 121 +---------------------------------------- > src/util/virnuma.c | 125 +++++++++++++++++++++++++++++++++++++++++++ > src/util/virnuma.h | 45 ++++++++++++++++ > tools/virsh-domain.c | 4 +- > 11 files changed, 192 insertions(+), 291 deletions(-) > > diff --git PATCH v3include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > index f6a7aff..b3bfd1d 100644 > --- PATCH v3include/libvirt/libvirt.h.in > +++ b/include/libvirt/libvirt.h.in > @@ -1762,21 +1762,6 @@ typedef enum { > /* Manage numa parameters */ > > /** > - * virDomainNumatuneMemMode: > - * Representation of the various modes in the<numatune> element of > - * a domain. > - */ > -typedef enum { > - VIR_DOMAIN_NUMATUNE_MEM_STRICT = 0, > - VIR_DOMAIN_NUMATUNE_MEM_PREFERRED = 1, > - VIR_DOMAIN_NUMATUNE_MEM_INTERLEAVE = 2, > - > -#ifdef VIR_ENUM_SENTINELS > - VIR_DOMAIN_NUMATUNE_MEM_LAST /* This constant is subject to change */ > -#endif > -} virDomainNumatuneMemMode; > - NACK, this will introduce backward compatibility problems. They should *not* be changed or removed.