On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote:
Convert these test cases to use DO_TEST_CAPS_LATEST
* os-firmware-bios * os-firmware-efi * os-firmware-efi-secboot
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- .../os-firmware-bios.x86_64-latest.xml | 68 +++++++++++++++++++ tests/qemuxml2xmloutdata/os-firmware-bios.xml | 1 - .../os-firmware-efi-secboot.x86_64-latest.xml | 68 +++++++++++++++++++ .../os-firmware-efi-secboot.xml | 1 - .../os-firmware-efi.x86_64-latest.xml | 68 +++++++++++++++++++ tests/qemuxml2xmloutdata/os-firmware-efi.xml | 1 - tests/qemuxml2xmltest.c | 27 +------- 7 files changed, 207 insertions(+), 27 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/os-firmware-bios.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-bios.xml create mode 100644 tests/qemuxml2xmloutdata/os-firmware-efi-secboot.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-efi-secboot.xml create mode 100644 tests/qemuxml2xmloutdata/os-firmware-efi.x86_64-latest.xml delete mode 120000 tests/qemuxml2xmloutdata/os-firmware-efi.xml
Not obvious from the diff, but I've verified manually that the new output files are identical to the old ones. [...]
+ DO_TEST_CAPS_LATEST("os-firmware-bios"); + DO_TEST_CAPS_LATEST("os-firmware-efi"); + DO_TEST_CAPS_LATEST("os-firmware-efi-secboot");
Again, we should add DO_TEST_CAPS_ARCH_LATEST("aarch64-os-firmware-efi", "aarch64"); too. Can, and perhaps should, be done in a separate patch. Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization