On 07/13/2017 10:41 AM, Michal Privoznik wrote:
On 06/02/2017 12:25 PM, John Ferlan wrote:
When creating an object, save the configFile name in the object rather than needing to build it up each time for the SaveConfig. This involves adding a @configDir parameter to virNWFilterObjListAssignDef and removing the @configDir from virNWFilterObjSaveConfig.
Why? This keeps the path in memory for the whole life time of the object even though it's needed just occasionally - at the beginning and probably at the end.
OK - again this is something that was originally from the broader scheme where a ConfigName could be saved in a more opaque object. We do it for secrets and storage, so this was a bit of monkey-see, monkey-do. John (I'm done for the day - I'll pick up looking at the rest of the review comments tomorrow).
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/virnwfilterobj.c | 38 ++++++++++++++++++++------------------ src/conf/virnwfilterobj.h | 6 +++--- src/nwfilter/nwfilter_driver.c | 5 +++-- 3 files changed, 26 insertions(+), 23 deletions(-)
Michal