Re: [libvirt] [Xen-devel] [PATCH RFC OSSTEST 7/9] Toolstack: Abstract away migration support check.
On Wed, 2014-06-25 at 09:25 -0600, Jim Fehlig wrote:
Ian Campbell wrote:
> On Tue, 2014-06-24 at 21:18 -0600, Jim Fehlig wrote:
>
>
>> Something like the attached patch (compile-tested only). You'll need an
>> updated libvirt.git master to apply cleanly.
>>
>
> Thanks. Building on ARM I get:
>
> libxl/libxl_driver.c:4346:1: error: 'libxlDomainMigrateBegin3Params' defined
but not used [-Werror=unused-function]
> libxl/libxl_driver.c:4384:1: error: 'libxlDomainMigratePrepare3Params'
defined but not used [-Werror=unused-function]
> libxl/libxl_driver.c:4433:1: error: 'libxlDomainMigratePerform3Params'
defined but not used [-Werror=unused-function]
> libxl/libxl_driver.c:4488:1: error: 'libxlDomainMigrateFinish3Params'
defined but not used [-Werror=unused-function]
> libxl/libxl_driver.c:4539:1: error: 'libxlDomainMigrateConfirm3Params'
defined but not used [-Werror=unused-function]
>
Yeah, compile-tested on x86 only as it turned out. I was building
packages in the build service, where I had the libxl driver disabled for
aarch64 :-/.
Whoops!
With the fixup, does this work for you? Is
<migration_features> omitted
from the capabilities?
Yes, it is omitted. On ARM:
# virsh capabilities
<capabilities>
<host>
<cpu>
<arch>armv7l</arch>
</cpu>
<power_management/>
<topology>
<cells num='1'>
<cell id='0'>
<memory unit='KiB'>4186112</memory>
<cpus num='4'>
<cpu id='0' socket_id='0' core_id='0'
siblings='0-3'/>
<cpu id='1' socket_id='0' core_id='0'
siblings='0-3'/>
<cpu id='2' socket_id='0' core_id='0'
siblings='0-3'/>
<cpu id='3' socket_id='0' core_id='0'
siblings='0-3'/>
</cpus>
</cell>
</cells>
</topology>
</host>
<guest>
<os_type>xen</os_type>
<arch name='armv7l'>
<wordsize>32</wordsize>
<emulator>/usr/lib/xen/bin/qemu-dm</emulator>
<machine>xenpv</machine>
<domain type='xen'>
</domain>
</arch>
</guest>
</capabilities>
Thanks,
Ian.