Re: [PATCH] util: virdaemon: fix waiting for child processes
On a Wednesday in 2020, Rafael Fonseca wrote:
On Tue, 7 Apr 2020, 22:14 Rafael Fonseca, <r4f4rfs(a)gmail.com>
wrote:
> Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0
> (success), so comparing that to `pid` will always be false and the
> parent will report failure with:
>
> error : main:851 : Failed to fork as daemon: No such file or directory
>
> even though the grandchild process is succesfully running. Note that the
> errno message is misleading: it was last set when trying to find a
> restart state file.
Thanks to Marcin Krol who found the issue and helped me debug it.
You can record his contribution in the git history if you'd like,
e.g.
Reported-by: Marcin Krol <his-e-mail>
Not sure there is a standard tag used for people helping with debugging.
The patch itself looks good to me, although thanks to use of these
helpers some code paths will report an error twice.
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)