John Levon <levon@movementarian.org> wrote:
On Fri, Jan 30, 2009 at 10:50:38AM -0800, john.levon@sun.com wrote:
Add <distro> to domain XML
Support recording the distro type and variant of a domain.
Comments? We obviously don't want to fork the XML, but consider being able to record this for debugging purposes very important.
Looks fine to me. Feature additions usually require *some* justification, and you've just provided it: "for debugging". Please mention that in the ChangeLog, too. In general, you'll get more from me as a reviewer if you say more in the change description or comments. The less I have to guess about the intent of a change, the better I can cross-check.
diff --git a/tests/xml2sexprdata/xml2sexpr-fv-distro.sexpr b/tests/xml2sexprdata/xml2sexpr-fv-distro.sexpr new file mode 100644 ... \ No newline at end of file
I know many other .sexpr files lack the final (sole) newline, but new ones should all have it.