On Wed, 2019-03-27 at 13:47 -0500, Eric Blake wrote: [...]
+# Create mock XDG files/directories to avoid permission problems. +# As it points inside $test_dir_, it is automatically cleaned. +mock_xdg_()
There doesn't seem to be a consistent pattern deciding when functions should be named_like_this() instead of being named_like_that_(), so I guess either one works fine.
+{ + export XDG_CONFIG_HOME="$test_dir_/.config" + export XDG_CACHE_HOME="$test_dir_/.cache" + export XDG_RUNTIME_HOME="XDG_CACHE_HOME"
Aren't you missing the $ in front of XDG_CACHE_HOME here? The same was actually true of the original incarnation of the code, too. With $XDG_RUNTIME_HOME set correctly, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization