Re: [libvirt] [vdsm] F17's libvirt takes comments into LIBVIRTD_ARGS
On Wed, May 16, 2012 at 11:56:36AM +0100, Daniel P. Berrange wrote:
On Wed, May 16, 2012 at 01:46:43PM +0300, Dan Kenigsberg wrote:
> On Tue, May 15, 2012 at 04:16:11PM +0800, Shu Ming wrote:
> I know that (see my text above). However, in F16 and before, comments have been
stripped
> before being passed to commandline. Have you tested if all is well when
> the commment is removed?
>
> Let's see what our friends in libvir-list think.
In F16 we were using the shell to launch libvirtd, in F17 we are
using systemd. systemd has stricter requirements around the syntax
of /etc/sysconfig/libvirtd file. Specifically it treats the entire
line as the value.
FYI I add a BZ for this against vdsm along with a suggested
solution
https://bugzilla.redhat.com/show_bug.cgi?id=821867
Oh and there is also a libvirt problem here, because we should not have
allowed these bogus argv to be passed - we should have raised an error
and exited
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|