Re: [libvirt] [PATCH] tests: run valgrind on real executables, not libtool wrappers

On 05/25/2012 10:48 AM, Eric Blake wrote: > * tests/Makefile.am (valgrind): Use libtool's ability to bypass > libtool wrappers when running valgrind. > --- > > I didn't think this was quite trivial enough to push without review. > Now that tests use libtool, we want to be sure to run valgrind on > the actual test, not on the bash shell that libtool uses to fire up > the real test. I also tested that this works even when there is no > libtool wrapper, such as when you disable modules for compilation. I just found the issue, 'make -C test valgrind' doesn't work for me. > tests/Makefile.am | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index c7addde..24818b1 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -244,7 +244,7 @@ TESTS_ENVIRONMENT = \ > > > valgrind: > - $(MAKE) check VG="valgrind --quiet --leak-check=full > --suppressions=$(srcdir)/.valgrind.supp" > + $(MAKE) check VG="libtool --mode=execute valgrind --quiet > --leak-check=full It works well for me with your patch.