On 05/23/2012 09:32 AM, Daniel P. Berrange wrote:
On Mon, May 21, 2012 at 08:59:09PM +0100, Daniel P. Berrange wrote:
This is the cause of the XenAPI build failure noted in patch 3.
Those 2 lines inside the if WITH_DRIVER_MODULES should have
also been deleted as they were for other entries, eg:
> libvirt_driver_esx_la_CFLAGS = $(LIBCURL_CFLAGS) \
> -I$(top_srcdir)/src/conf -I$(top_srcdir)/src/vmx $(AM_CFLAGS)
> libvirt_driver_esx_la_LDFLAGS = $(AM_LDFLAGS)
> libvirt_driver_esx_la_LIBADD = $(LIBCURL_LIBS)
> -if WITH_DRIVER_MODULES
> -libvirt_driver_esx_la_LIBADD += ../gnulib/lib/libgnu.la
> -libvirt_driver_esx_la_LDFLAGS += -module -avoid-version
> -endif
Yep, I confirmed that with this tweak, the rest of the series worked for
me with an in-tree build (again, see patch 7 for my concerns that we're
still a bit too hard-coded for unusual VPATH setups).
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org