Re: [libvirt] [PATCH 2/2] qemu: Enforce vCPU hotplug granularity constraints
On Fri, 2017-12-15 at 13:22 +0100, Peter Krempa wrote:
> +
> + if (!def->cpu || def->cpu->sockets == 0)
> + return 1;
I think we assume '1' as threads here if it's not specified.
Okay.
> +
> + if (qemuDomainIsPSeries(def))
> + *granularity = def->cpu->threads;
> + else
> + *granularity = 1;
Why not just return the granularity rather than this weirdness?
Sure, I can do that.
Does the rest of the patch look reasonable, or do you want to
point out anything else before I respin?
--
Andrea Bolognani / Red Hat / Virtualization