On Thu, Oct 07, 2010 at 09:45:28AM +0200, Gerd v. Egidy wrote:
I solved it and thought updating the documentation for PolicyKit 1 would be nice. Patch attached.
Is this patch still relevant against the latest sources? If so, would you mind resending it, so we can get it into 0.8.5?
Kind of thinking we may have fixed this already. The PolicyKit documentation has recently been updated, to reflect the new(er) way of doing things with it:
http://libvirt.org/auth.html#ACL_server_polkit
and
These pages together go more into detail and offer more examples than my patch did.
Just checked Gerd's patch, and the PolicyKit-0 stuff seems useful, as well as the example (which I haven't tested).
The PolicyKit-0 stuff was in there before, I just kept it and added PolicyKit-1. I don't think we need the PolicyKit-0 documentation anymore, everyone using current libvirt is most probably also using PolicyKit-1.
As long as the code for pk0 exists, we should keep the corresponding documentation. I don't want to delete the code yet, because it really hasn't been that long since it was in use Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|