On Thu, Feb 29, 2024 at 04:00:37PM +0100, Martin Kletzander wrote:
On Mon, Nov 13, 2023 at 10:22:59AM +0000, Benjamin Taubmann wrote:
At the moment, there is no configuration option for the libvirt-guests service that allows users to define that only persistent virtual machines should be shutdown on host shutdown.
Currently, the service config allows to choose between two ON_SHUTDOWN actions that are executed on running virtual machines when the host goes down: shutdown, suspend. The ON_SHUTDOWN action should be orthogonal to the type of the virtual machine. However, the existing implementation, does not suspend transient virtual machines. This is the matrix of actions that is executed on virtual machines based on the configured ON_SHUTDOWN action and the type of a virtual machine.
| persistent | transient shutdown | shutdown | shutdown (what we want to change) suspend | suspend | nothing
Add config option PERSISTENT_ONLY to libvirt-guests config that allows users to define if the ON_SHUTDOWN action should be applied only on persistent virtual machines. PERSISTENT_ONLY can be set to true, false, default. The default option will implement the already existing logic.
Case 1: PERSISTENT_ONLY=default | persistent | transient shutdown | shutdown | shutdown suspend | suspend | nothing
Case 2: PERSISTENT_ONLY=true | persistent | transient shutdown | shutdown | nothing suspend | suspend | nothing
Case 3: PERSISTENT_ONLY=false | persistent | transient shutdown | shutdown | shutdown suspend | suspend | suspend
Change-Id: Ib03013d00b3ec60716287dad4743a038cf000763
Sorry for the delay.
I'm not sure what this Change-Id is or what it tracks, we don't use anything like it.
What we need, however, is your sign-off for every patch, see
https://libvirt.org/hacking.html#developer-certificate-of-origin
and git history.
With that added this is
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
Please don't forget to update docs/manpages/libvirt-guests.rst with information about this feature too. -- Andrea Bolognani / Red Hat / Virtualization