Re: [libvirt] [PATCH 2/3] Refactor storage code to use common functions for LU discovery for all SCSI transports.
On Mon, Mar 02, 2009 at 02:41:12PM -0500, David Allan wrote:
---
src/storage_backend_iscsi.c | 327 +---------------------
src/storage_backend_scsi.c | 649 ++++++++++++++++++++-----------------------
src/storage_backend_scsi.h | 22 +-
3 files changed, 319 insertions(+), 679 deletions(-)
ACK, this turned out quite nicely really. The patch diff context is hard
to follow, but the resulting code after applying the patch looks good to
me
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|