On Wed, May 16, 2018 at 04:56:24PM +0200, Andrea Bolognani wrote:
On Tue, 2018-05-15 at 18:54 +0100, Daniel P. Berrangé wrote: [...]
diff --git a/prepare-release.sh b/prepare-release.sh index fea03f4..6850350 100755 --- a/prepare-release.sh +++ b/prepare-release.sh @@ -4,52 +4,18 @@ NAME=Sys-Virt
set -e
-test -n "$1" && RESULTS=$1 || RESULTS=results.log +rm -rf blib _build Build $NAME-*.tar.gz
-make -k realclean ||: -rm -rf MANIFEST blib pm_to_blib +test -z "$AUTOBUILD_INSTALL_ROOT" && AUTOBUILD_INSTALL_ROOT=$HOME/builder
Please don't reintroduce $AUTOBUILD_INSTALL_ROOT: just leave this line alone and...
Opps, yes, my bad syncing from outdated libvirt-tck
export TEST_MAINTAINER=1
-perl Makefile.PL PREFIX=$HOME/builder +perl Build.PL install_base=$AUTOBUILD_INSTALL_ROOT
... use install_base=$HOME/builder here.
With the caveat that I know nothing about Perl, the changes look sane enough and I tested them without running into any issue, so
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Please coordinate before pushing to make sure the CI environment has been updated by the time the first Module::Build is triggered.
-- Andrea Bolognani / Red Hat / Virtualization
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|