Re: [libvirt] [PATCHv3] qemu: add a check for slot and base when build dimm address

On 06/15/2015 08:33 AM, Luyao Huang wrote: > When hot-plug a memory device, we don't check if there > is a memory device have the same address with the memory device > we want hot-pluged. Qemu forbid use/hot-plug 2 memory device > with same slot or the same base(qemu side this elemnt named addr). > > Introduce a address check when build memory device qemu command line. > > Signed-off-by: Luyao Huang <lhuang(a)redhat.com&gt; > --- NOTE: Used the following for commit message: qemu: Add a check for slot and base dimm address conflicts When hotplugging a memory device, there wasn't a check to determine if there is a conflict with the address space being used by the to be added memory device and any existing device which is disallowed by qemu. This patch adds a check to ensure the new device address doesn't conflict with any existing device.

> v3: > rename qemuBuildMemoryDeviceAddr to qemuCheckMemoryDimmConflict and > remove the refactor. > > src/qemu/qemu_command.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > ACK Adjusted patch as shown below and pushed.

John