Re: [libvirt] [libvirt-java] [PATCH] Avoid calling processError for functions that cannot fail

At Wed, 8 Jan 2014 16:25:30 +0100, Claudio Bley wrote: > > The libvirt functions virNodeDeviceNumOfCaps, virNodeDeviceGetParent > and virNodeDeviceListCaps never indicate an error because they do not > fail. > --- > src/main/java/org/libvirt/Device.java | 19 ++++++------------- > src/main/java/org/libvirt/jna/Libvirt.java | 2 +- > 2 files changed, 7 insertions(+), 14 deletions(-) > > diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java > index b026b04..a2bf42e 100644 > --- a/src/main/java/org/libvirt/jna/Libvirt.java > +++ b/src/main/java/org/libvirt/jna/Libvirt.java > @@ -281,7 +281,7 @@ public interface Libvirt extends Library { > String virNodeDeviceGetName(DevicePointer virDevicePointer); > String virNodeDeviceGetParent(DevicePointer virDevicePointer); > int virNodeDeviceNumOfCaps(DevicePointer virDevicePointer); > - int virNodeDeviceListCaps(DevicePointer virDevicePointer, String[] names, int maxNames); > + int virNodeDeviceListCaps(DevicePointer virDevicePointer, Pointer[] names, int maxNames); > String virNodeDeviceGetXMLDesc(DevicePointer virDevicePointer); > int virNodeDeviceFree(DevicePointer virDevicePointer); > int virNodeDeviceDettach(DevicePointer virDevicePointer); I just realized that this hunk does not belong to the patch. Please ignore it when reviewing.