Re: [libvirt] [PATCH v2 01/10] docs: Clarify unprivileged sgio feature for host devices

On Mon, Jul 06, 2015 at 13:08:29 -0400, John Ferlan wrote: > Not all kernels support SG_IO for host devices, so let's indicate so > > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > docs/formatdomain.html.in | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > index ea2fff8..0fc5d85 100644 > --- a/docs/formatdomain.html.in > +++ b/docs/formatdomain.html.in > @@ -3232,11 +3232,12 @@ > </dd> > <dt>scsi</dt> > <dd>For SCSI devices, user is responsible to make sure the device > - is not used by host. The optional <code>sgio</code> > + is not used by host. If supported by the kernel, I'd rather see us state that it has to be supported by the hypervisor, rather than kernel since hostdevs may be supported on non-linux platforms too. > + the optional <code>sgio</code> > (<span class="since">since 1.0.6</span>) attribute indicates > whether the kernel will filter unprivileged SG_IO commands for > - the disk, valid settings are "filtered" or "unfiltered". > - The default is "filtered". The optional <code>rawio</code> > + the disk. Valid settings are "filtered" or "unfiltered" where > + the default is "filtered". The optional <code>rawio</code> > (<span class="since">since 1.2.9</span>) attribute indicates > whether the lun needs the rawio capability. Valid settings are > "yes" or "no". See the rawio description within thea But since this is already linux specific I gues I don't care enough to enforce the above comment.