On Thu, Feb 20, 2014 at 06:17:31AM -0700, Eric Blake wrote:
On 12/18/2013 05:22 AM, Daniel P. Berrange wrote:
Wow, this one has sat for a while.
The virDomainGetRootFilesystem method can be generalized to allow any filesystem path to be obtained.
While doing this, start a new test case for purpose of testing various helper methods in the domain_conf.{c,h} files, such as this one.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> ---
+++ b/src/lxc/lxc_container.c @@ -1823,7 +1823,7 @@ static int lxcContainerChild(void *data) if (lxcContainerSetID(vmDef) < 0) goto cleanup;
- root = virDomainGetRootFilesystem(vmDef); + root = virDomainGetFilesystemForTarget(vmDef, "/");
Looks okay to me.
+++ b/tests/domainconftest.c @@ -0,0 +1,120 @@ +/* + * Copyright (C) 2013 Red Hat, Inc.
You may want to add 2014 to the new files.
ACK.
Opps, completely forgot about this patch. Twice. Now pushed. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|