Re: [libvirt] [PATCH 2/4] parallels: don't forget to unlock domain in parallelsDomainHasManagedSaveImage

On Tue, Mar 10, 2015 at 23:12:20 +0300, Maxim Nestratov wrote:

Signed-off-by: Maxim Nestratov <mnestratov@parallels.com> --- src/parallels/parallels_driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index 09d1cca..bbe9450 100644 --- a/src/parallels/parallels_driver.c +++ b/src/parallels/parallels_driver.c @@ -973,6 +973,9 @@ parallelsDomainHasManagedSaveImage(virDomainPtr domain, unsigned int flags) return -1; }

+ if (dom)

No need to check dom here. It is guaranteed to be set at this point. As it might set off our coverity checker I'll touch up the patch.

+ virObjectUnlock(dom); + return 0; }

ACK, Peter